OSDN Git Service

net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used
authorRemi Pommarel <repk@triplefau.lt>
Sun, 8 Mar 2020 09:25:56 +0000 (10:25 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Mar 2020 04:27:44 +0000 (21:27 -0700)
commitb723bd933980f4956dabc8a8d84b3e83be8d094c
treec225cde763c23d135e526ebdaf72c4e81530134c
parent17c25cafd4d3e74c83dce56b158843b19c40b414
net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used

ACS (auto PAD/FCS stripping) removes FCS off 802.3 packets (LLC) so that
there is no need to manually strip it for such packets. The enhanced DMA
descriptors allow to flag LLC packets so that the receiving callback can
use that to strip FCS manually or not. On the other hand, normal
descriptors do not support that.

Thus in order to not truncate LLC packet ACS should be disabled when
using normal DMA descriptors.

Fixes: 47dd7a540b8a0 ("net: add support for STMicroelectronics Ethernet controllers.")
Signed-off-by: Remi Pommarel <repk@triplefau.lt>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c