OSDN Git Service

phy: broadcom: phy-brcm-usb: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 7 Mar 2023 11:58:31 +0000 (12:58 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 20 Mar 2023 12:44:56 +0000 (18:14 +0530)
commitb762d7d39d32859728f4d847c3f3c9705833f6dd
tree811d8b9c5bf99c6fa305e3e19e6a9012fadbfc93
parentb4700ed86f00d1917f5219c861f425f92af1a7ef
phy: broadcom: phy-brcm-usb: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Justin Chen <justinpopo6@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20230307115900.2293120-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/broadcom/phy-brcm-usb.c