OSDN Git Service

RDMA/umem: Avoid undefined behavior of rounddown_pow_of_two()
authorAharon Landau <aharonl@nvidia.com>
Wed, 13 Jan 2021 12:16:59 +0000 (14:16 +0200)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 14 Jan 2021 16:50:17 +0000 (12:50 -0400)
commitb79f2dc5ffe17b03ec8c55f0d63f65e87bcac676
tree895aa1515365389bda7639cb958c85f55ff739c8
parentf2bc3af6353cb2a33dfa9d270d999d839eef54cb
RDMA/umem: Avoid undefined behavior of rounddown_pow_of_two()

rounddown_pow_of_two() is undefined when the input is 0. Therefore we need
to avoid it in ib_umem_find_best_pgsz and return 0.  Otherwise, it could
result in not rejecting an invalid page size which eventually causes a
kernel oops due to the logical inconsistency.

Fixes: 3361c29e9279 ("RDMA/umem: Use simpler logic for ib_umem_find_best_pgsz()")
Link: https://lore.kernel.org/r/20210113121703.559778-2-leon@kernel.org
Signed-off-by: Aharon Landau <aharonl@nvidia.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/core/umem.c