OSDN Git Service

hw/dma: sifive_pdma: Fix Control.claim bit detection
authorBin Meng <bmeng.cn@gmail.com>
Mon, 27 Sep 2021 07:21:23 +0000 (15:21 +0800)
committerAlistair Francis <alistair.francis@wdc.com>
Wed, 6 Oct 2021 22:41:33 +0000 (08:41 +1000)
commitb7af62ae2ca4a5f36a36d98e37d59e96fb3f8ef5
tree047c1e4cf7ff7c4942f13d758a32902f0ef380f8
parent31ca70b5ff7c6ac600211f60e3ab024642fe5abb
hw/dma: sifive_pdma: Fix Control.claim bit detection

At present the codes detect whether the DMA channel is claimed by:

  claimed = !!s->chan[ch].control & CONTROL_CLAIM;

As ! has higher precedence over & (bitwise and), this is essentially

  claimed = (!!s->chan[ch].control) & CONTROL_CLAIM;

which is wrong, as any non-zero bit set in the control register will
produce a result of a claimed channel.

Fixes: de7c7988d25d ("hw/dma: sifive_pdma: reset Next* registers when Control.claim is set")
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20210927072124.1564129-1-bmeng.cn@gmail.com
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/dma/sifive_pdma.c