OSDN Git Service

xen-block: Fix removal of backend instance via xenstore
authorAnthony PERARD <anthony.perard@citrix.com>
Mon, 8 Mar 2021 14:32:32 +0000 (14:32 +0000)
committerAnthony PERARD <anthony.perard@citrix.com>
Tue, 23 Mar 2021 11:18:20 +0000 (11:18 +0000)
commitb807ca3fa0ca29ec015adcf4045e716337cd3635
treef9941aa8066a4425cdde935e6d1e70c569c7a28d
parent5ca634afcf83215a9a54ca6e66032325b5ffb5f6
xen-block: Fix removal of backend instance via xenstore

Whenever a Xen block device is detach via xenstore, the image
associated with it remained open by the backend QEMU and an error is
logged:
    qemu-system-i386: failed to destroy drive: Node xvdz-qcow2 is in use

This happened since object_unparent() doesn't immediately frees the
object and thus keep a reference to the node we are trying to free.
The reference is hold by the "drive" property and the call
xen_block_drive_destroy() fails.

In order to fix that, we call drain_call_rcu() to run the callback
setup by bus_remove_child() via object_unparent().

Fixes: 2d24a6466154 ("device-core: use RCU for list of children of a bus")

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Message-Id: <20210308143232.83388-1-anthony.perard@citrix.com>
hw/block/xen-block.c