OSDN Git Service

events: Reuse value read using READ_ONCE instead of re-reading it
authorBaptiste Lepers <baptiste.lepers@gmail.com>
Mon, 6 Sep 2021 01:53:10 +0000 (11:53 +1000)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 15 Sep 2021 15:49:06 +0000 (17:49 +0200)
commitb89a05b21f46150ac10a962aa50109250b56b03b
treee4a85375c8fbeef5edd0fc1fba90d47bc23835df
parent6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
events: Reuse value read using READ_ONCE instead of re-reading it

In perf_event_addr_filters_apply, the task associated with
the event (event->ctx->task) is read using READ_ONCE at the beginning
of the function, checked, and then re-read from event->ctx->task,
voiding all guarantees of the checks. Reuse the value that was read by
READ_ONCE to ensure the consistency of the task struct throughout the
function.

Fixes: 375637bc52495 ("perf/core: Introduce address range filtering")
Signed-off-by: Baptiste Lepers <baptiste.lepers@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20210906015310.12802-1-baptiste.lepers@gmail.com
kernel/events/core.c