OSDN Git Service

PCI: Align PCIe capability and PCI accessor return values
authorBolarinwa Olayemi Saheed <refactormyself@gmail.com>
Mon, 15 Jun 2020 07:32:25 +0000 (09:32 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 26 Jun 2020 18:50:41 +0000 (13:50 -0500)
commitb91535812d663acc47952d05386c8a126eae8080
treeeb430110d95108302d63c5a6ff23bf871eec1383
parentd20df83b66ccb9cc6b1ac448d4013647a0fe4952
PCI: Align PCIe capability and PCI accessor return values

The PCI config accessors (pci_read_config_word(), et al) return
PCIBIOS_SUCCESSFUL (zero) or positive error values like
PCIBIOS_FUNC_NOT_SUPPORTED.

The PCIe capability accessors similarly return PCIBIOS errors, but in
addition, they can return -EINVAL.  This makes it harder than it should be
to check for errors.

Return PCIBIOS_BAD_REGISTER_NUMBER instead of -EINVAL in all PCIe
capability accessors.

Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
Link: https://lore.kernel.org/r/20200615073225.24061-9-refactormyself@gmail.com
Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/access.c