OSDN Git Service

hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Wed, 15 Dec 2021 18:24:19 +0000 (19:24 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 20 Jan 2022 16:04:58 +0000 (16:04 +0000)
commitb9d383ab797f54ae5fa8746117770709921dc529
tree6727727d2953e4122bffacc2715edff3b42346b5
parent58b88779f00707b6231d827637b5a3d498f9fe28
hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR

Quoting Peter Maydell:

 "These MEMTX_* aren't from the memory transaction
  API functions; they're just being used by gicd_readl() and
  friends as a way to indicate a success/failure so that the
  actual MemoryRegionOps read/write fns like gicv3_dist_read()
  can log a guest error."

We are going to introduce more MemTxResult bits, so it is
safer to check for !MEMTX_OK rather than MEMTX_ERROR.

Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/intc/arm_gicv3_redist.c