OSDN Git Service

powerpc/modules: Don't try to restore r2 after a sibling call
authorJosh Poimboeuf <jpoimboe@redhat.com>
Thu, 16 Nov 2017 17:45:37 +0000 (11:45 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 11 Dec 2017 02:03:29 +0000 (13:03 +1100)
commitb9eab08d012fa093947b230f9a87257c27fb829b
treefa5f33c519c97d9cbbf59b4598a8fdf8e8f4d273
parenta443bf6e8a7674b86221f4922cae82d67dc9e8ad
powerpc/modules: Don't try to restore r2 after a sibling call

When attempting to load a livepatch module, I got the following error:

  module_64: patch_module: Expect noop after relocate, got 3c820000

The error was triggered by the following code in
unregister_netdevice_queue():

  14c:   00 00 00 48     b       14c <unregister_netdevice_queue+0x14c>
                         14c: R_PPC64_REL24      net_set_todo
  150:   00 00 82 3c     addis   r4,r2,0

GCC didn't insert a nop after the branch to net_set_todo() because it's
a sibling call, so it never returns.  The nop isn't needed after the
branch in that case.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Reviewed-and-tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/include/asm/code-patching.h
arch/powerpc/kernel/module_64.c
arch/powerpc/lib/code-patching.c