OSDN Git Service

[ARM] Promote small global constants to constant pools
authorJames Molloy <james.molloy@arm.com>
Mon, 26 Sep 2016 07:26:24 +0000 (07:26 +0000)
committerJames Molloy <james.molloy@arm.com>
Mon, 26 Sep 2016 07:26:24 +0000 (07:26 +0000)
commitba54dc2e883758a2bcc45555308d1186a2180176
tree0b09853aefb31b79ef90e7ef254f9558f4b6c368
parent9209299b97428cbc58ac68152850f445024ff96c
[ARM] Promote small global constants to constant pools

If a constant is unamed_addr and is only used within one function, we can save
on the code size and runtime cost of an indirection by changing the global's storage
to inside the constant pool. For example, instead of:

      ldr r0, .CPI0
      bl printf
      bx lr
    .CPI0: &format_string
    format_string: .asciz "hello, world!\n"

We can emit:

      adr r0, .CPI0
      bl printf
      bx lr
    .CPI0: .asciz "hello, world!\n"

This can cause significant code size savings when many small strings are used in one
function (4 bytes per string).

This recommit contains fixes for a nasty bug related to fast-isel fallback - because
fast-isel doesn't know about this optimization, if it runs and emits references to
a string that we inline (because fast-isel fell back to SDAG) we will end up
with an inlined string and also an out-of-line string, and we won't emit the
out-of-line string, causing backend failures.

It also contains fixes for emitting .text relocations which made the sanitizer
bots unhappy.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@282387 91177308-0d34-0410-b5e6-96231b3b80d8
lib/CodeGen/MachineFunction.cpp
lib/Target/ARM/ARMAsmPrinter.cpp
lib/Target/ARM/ARMAsmPrinter.h
lib/Target/ARM/ARMConstantIslandPass.cpp
lib/Target/ARM/ARMConstantPoolValue.cpp
lib/Target/ARM/ARMConstantPoolValue.h
lib/Target/ARM/ARMISelLowering.cpp
lib/Target/ARM/ARMMachineFunctionInfo.cpp
lib/Target/ARM/ARMMachineFunctionInfo.h
test/CodeGen/ARM/constantpool-promote-dbg.ll [new file with mode: 0644]
test/CodeGen/ARM/constantpool-promote.ll [new file with mode: 0644]