OSDN Git Service

aio-posix: disable fdmon-io_uring when GSource is used
authorStefan Hajnoczi <stefanha@redhat.com>
Mon, 11 May 2020 18:36:30 +0000 (19:36 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 18 May 2020 17:16:00 +0000 (18:16 +0100)
commitba607ca8bff4d2c2062902f8355657c865ac7c29
treede002f3ab22e267501feb4b691e51c22662b1753
parentde137e44f75d9868f5b548638081850f6ac771f2
aio-posix: disable fdmon-io_uring when GSource is used

The glib event loop does not call fdmon_io_uring_wait() so fd handlers
waiting to be submitted build up in the list. There is no benefit is
using io_uring when the glib GSource is being used, so disable it
instead of implementing a more complex fix.

This fixes a memory leak where AioHandlers would build up and increasing
amounts of CPU time were spent iterating them in aio_pending(). The
symptom is that guests become slow when QEMU is built with io_uring
support.

Buglink: https://bugs.launchpad.net/qemu/+bug/1877716
Fixes: 73fd282e7b6dd4e4ea1c3bbb3d302c8db51e4ccf ("aio-posix: add io_uring fd monitoring implementation")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Oleksandr Natalenko <oleksandr@redhat.com>
Message-id: 20200511183630.279750-3-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
include/block/aio.h
util/aio-posix.c
util/aio-win32.c
util/async.c