OSDN Git Service

net: mscc: ocelot: remove buggy duplicate write to DEV_CLOCK_CFG
authorColin Foster <colin.foster@in-advantage.com>
Fri, 17 Sep 2021 15:39:05 +0000 (08:39 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 19 Sep 2021 11:59:52 +0000 (12:59 +0100)
commitba68e9941984792f7e8a7be90b8245eb0d2b4d7b
treeeea6314ffcf55f731092d66a8c1035e2467f41ce
parent163957c43d96c2409d9d9d2e94823f7300f6e52c
net: mscc: ocelot: remove buggy duplicate write to DEV_CLOCK_CFG

When updating ocelot to use phylink, a second write to DEV_CLOCK_CFG was
mistakenly left in. It used the variable "speed" which, previously, would
would have been assigned a value of OCELOT_SPEED_1000. In phylink the
variable is be SPEED_1000, which is invalid for the
DEV_CLOCK_LINK_SPEED macro. Removing it as unnecessary and buggy.

Fixes: e6e12df625f2 ("net: mscc: ocelot: convert to phylink")
Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mscc/ocelot.c