OSDN Git Service

dmaengine: Cleanups for the slave <-> channel symlink support
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Fri, 31 Jan 2020 09:38:58 +0000 (11:38 +0200)
committerVinod Koul <vkoul@kernel.org>
Mon, 3 Feb 2020 04:19:20 +0000 (09:49 +0530)
commitbad83565eafe8a00922ad4eed6920625a10a2126
tree0bb78155e54d75a298efd6d8641d27b1b33d71a3
parent5429b51f606cb82f315f68678b959112766f235e
dmaengine: Cleanups for the slave <-> channel symlink support

No need to use goto to jump over the
return chan ? chan : ERR_PTR(-EPROBE_DEFER);
We can just revert the check and return right there.

Do not fail the channel request if the chan->name allocation fails, but
print a warning about it.

Change the dev_err to dev_warn if sysfs_create_link() fails as it is not
fatal.

Only attempt to remove the DMA_SLAVE_NAME symlink if it is created - or it
was attempted to be created.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20200131093859.3311-2-peter.ujfalusi@ti.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dmaengine.c