OSDN Git Service

spi: omap2-mcspi: Fix DMA and FIFO event trigger size mismatch
authorVignesh R <vigneshr@ti.com>
Tue, 15 Jan 2019 06:58:32 +0000 (12:28 +0530)
committerMark Brown <broonie@kernel.org>
Tue, 15 Jan 2019 13:17:04 +0000 (13:17 +0000)
commitbaf8b9f8d260c55a86405f70a384c29cda888476
treec24ed26f0305ea7aa105c028ea1313d7ffa65c92
parentaa54c1c9d90e6db75190813907190fadcce1bf45
spi: omap2-mcspi: Fix DMA and FIFO event trigger size mismatch

Commit b682cffa3ac6 ("spi: omap2-mcspi: Set FIFO DMA trigger level to word length")
broke SPI transfers where bits_per_word != 8. This is because of
mimsatch between McSPI FIFO level event trigger size (SPI word length) and
DMA request size(word length * maxburst). This leads to data
corruption, lockup and errors like:

spi1.0: EOW timed out

Fix this by setting DMA maxburst size to 1 so that
McSPI FIFO level event trigger size matches DMA request size.

Fixes: b682cffa3ac6 ("spi: omap2-mcspi: Set FIFO DMA trigger level to word length")
Cc: stable@vger.kernel.org
Reported-by: David Lechner <david@lechnology.com>
Tested-by: David Lechner <david@lechnology.com>
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-omap2-mcspi.c