OSDN Git Service

Remove the double lists in WifiTracker.
authorSundeep Ghuman <sghuman@google.com>
Tue, 30 Jan 2018 02:31:15 +0000 (18:31 -0800)
committerSundeep Ghuman <sghuman@google.com>
Wed, 14 Feb 2018 19:52:55 +0000 (11:52 -0800)
commitbb39991c525f69cc5ed3829ab13abff7c4e721ef
treea2007b4554b43f972d88a132a0b51b137891710c
parent91f4ccb4b7ea6136da1f8f2ee49f7eea281126b9
Remove the double lists in WifiTracker.

This CL completes the final removal of the double handler, double list,
pending notification complexity that was introduced ag/1396615 as a
'fix' to improper API implementation of the AccessPointListener
callback. The implementation erroneously refetched the entire
WifiTracker list and then performed its own sorting everytime an
individual AccessPoint was updated, instead of waiting for WifiTracker's
WifiListener.onAccessPointsChanged (plural) method instead.

Those changes have now been reverted, and the underlying SetupWizard
code has changed since then such that it does not need to be modified to
prevent regressions.

Bug: 37674366
Test: 1. runtest --path
    frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java
2. runtest --path
    frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
3. Manual testing of WifiSettings for visual jank
4. Startup and manual inspection of SetupWizard Wifi Picker.

Change-Id: Ia4079859a7a892983ecf55ba8eab13d20120ff99
packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java
packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java
packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java