OSDN Git Service

net: dsa: microchip: remove ksz_port:on variable
authorOleksij Rempel <o.rempel@pengutronix.de>
Fri, 26 May 2023 07:34:43 +0000 (09:34 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 30 May 2023 07:48:17 +0000 (09:48 +0200)
commitbb4609d27f89cf6d4c6021690c02a10a94719464
tree634f75f0064ac46325ec31d5477a83aa42bc438f
parentb8311f46c6f5a2030f43c764e742015867293493
net: dsa: microchip: remove ksz_port:on variable

The only place where this variable would be set to false is the
ksz8_config_cpu_port() function. But it is done in a bogus way:

  for (i = 0; i < dev->phy_port_cnt; i++) {
if (i == dev->phy_port_cnt) <--- will be never executed.
break;
p->on = 1;

So, we never have a situation where p->on = 0. In this case, we can just
remove it.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/dsa/microchip/ksz8795.c
drivers/net/dsa/microchip/ksz_common.h