OSDN Git Service

nvdimm: Allow overwrite in the presence of disabled dimms
authorDan Williams <dan.j.williams@intel.com>
Thu, 28 Apr 2022 22:47:46 +0000 (15:47 -0700)
committerDan Williams <dan.j.williams@intel.com>
Thu, 28 Apr 2022 22:47:46 +0000 (15:47 -0700)
commitbb7bf697fed58eae9d3445944e457ab0de4da54f
tree25f9f7c032abac07ee1932f8572cb08f41628c78
parentdbbf16895a89953ccbcf0dab2806821b1ec565ff
nvdimm: Allow overwrite in the presence of disabled dimms

It is not clear why the original implementation of overwrite support
required the dimm driver to be active before overwrite could proceed. In
fact that can lead to cases where the kernel retains an invalid cached
copy of the labels from before the overwrite. Unfortunately the kernel
has not only allowed that case, but enforced it.

Going forward, allow for overwrite to happen while the label area is
offline, and follow-on with updates to 'ndctl sanitize-dimm --overwrite'
to trigger the label area invalidation by default.

Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Reported-by: Krzysztof Kensicki <krzysztof.kensicki@intel.com>
Fixes: 7d988097c546 ("acpi/nfit, libnvdimm/security: Add security DSM overwrite support")
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/security.c