OSDN Git Service

ALSA: hda_codec: Replace zero-length array with flexible-array member
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 11 Feb 2020 20:07:39 +0000 (14:07 -0600)
committerTakashi Iwai <tiwai@suse.de>
Wed, 12 Feb 2020 07:14:47 +0000 (08:14 +0100)
commitbb80b96422b443ddcb6dbb39261ea3e02a13661d
tree6f4efe78aaf3c7429daf91e481faf989c9537e7b
parent76501954cb9ef5b3d614a075870cfce47fbbd6df
ALSA: hda_codec: Replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20200211200739.GA12948@embeddedor
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_codec.c