OSDN Git Service

dm io: fix duplicate bio completion due to missing ref count
authorMike Snitzer <snitzer@redhat.com>
Tue, 20 Jun 2017 23:14:30 +0000 (19:14 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Mar 2018 15:19:47 +0000 (16:19 +0100)
commitbb97a65730f975743b2d95b5cecadc5a254c0159
tree325a85bcf5facf5f4b22c8e711e467d3ced6d5b4
parente7f17d033e58acce9df40bc44ed804720417ca2e
dm io: fix duplicate bio completion due to missing ref count

commit feb7695fe9fb83084aa29de0094774f4c9d4c9fc upstream.

If only a subset of the devices associated with multiple regions support
a given special operation (eg. DISCARD) then the dec_count() that is
used to set error for the region must increment the io->count.

Otherwise, when the dec_count() is called it can cause the dm-io
caller's bio to be completed multiple times.  As was reported against
the dm-mirror target that had mirror legs with a mix of discard
capabilities.

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=196077
Reported-by: Zhang Yi <yizhan@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm-io.c