OSDN Git Service

pinctrl: zte: fix 'functions' allocation in zx_pinctrl_build_state()
authorShawn Guo <shawn.guo@linaro.org>
Sun, 16 Jul 2017 13:33:28 +0000 (21:33 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 14 Aug 2017 13:01:01 +0000 (15:01 +0200)
commitbba2e8712602e2d8192f748f588910d1534e4baf
tree41ff63165211f8e27e43432d87d65e00eafbc7c0
parent8939aa5f5164b51b7ebd269a0443c8cd222214c4
pinctrl: zte: fix 'functions' allocation in zx_pinctrl_build_state()

It fixes the following Smatch static check warning:

 drivers/pinctrl/zte/pinctrl-zx.c:338 zx_pinctrl_build_state()
 warn: passing devm_ allocated variable to kfree.

As we will be calling krealloc() on pointer 'functions', which means
kfree() will be called in there, devm_kzalloc() shouldn't be used with
the allocation in the first place.  Fix the warning by calling kcalloc()
and managing the free procedure in error path on our own.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: cbff0c4d27f4 ("pinctrl: add ZTE ZX pinctrl driver support")
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/zte/pinctrl-zx.c