OSDN Git Service

tick-sched: avoid a maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 9 Apr 2018 12:23:33 +0000 (14:23 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 10 Apr 2018 07:18:04 +0000 (09:18 +0200)
commitbbe9a70a478129f3f9b2003415d0c36afcea210f
treee69c1d48fbe29e0e7d1d11270966e78f75b177c3
parent792ccb457ade4107ad9f1892cb23b78c13a10fb1
tick-sched: avoid a maybe-uninitialized warning

The use of bitfields seems to confuse gcc, leading to a false-positive
warning in all compiler versions:

kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit':
kernel/time/tick-sched.c:538:2: error: 'now' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This introduces a temporary variable to track the flags so gcc
doesn't have to evaluate twice, eliminating the code path that
leads to the warning.

Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85301
Fixes: 1cae544d42d2 ("nohz: Gather tick_sched booleans under a common flag field")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/time/tick-sched.c