OSDN Git Service

nvmet: use try_cmpxchg in nvmet_update_sq_head
authorUros Bizjak <ubizjak@gmail.com>
Thu, 20 Oct 2022 15:35:40 +0000 (17:35 +0200)
committerChristoph Hellwig <hch@lst.de>
Tue, 15 Nov 2022 09:49:48 +0000 (10:49 +0100)
commitbbf5410bc69e131c82ad970ce7ee28b5906a6cc5
tree93af6677b80cc96e9b3508f227e682d7d7b639a7
parent5626196a5ae0937368b35c3625c428a2125b0f44
nvmet: use try_cmpxchg in nvmet_update_sq_head

Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
nvmet_update_sq_head.  x86 CMPXCHG instruction returns success in ZF flag, so
this change saves a compare after cmpxchg (and related move instruction in
front of cmpxchg).

Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
fails. There is no need to re-read the value in the loop.

Note that the value from *ptr should be read using READ_ONCE to prevent
the compiler from merging, refetching or reordering the read.

No functional change intended.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/core.c