OSDN Git Service

btrfs: return error pointer from alloc_test_extent_buffer
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 3 Dec 2019 11:24:58 +0000 (14:24 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 Jan 2020 12:34:19 +0000 (13:34 +0100)
commitbc6c9967a8ef07741ade4bec0284a07e5d784bc8
treea8fa04ad60cd1978747742f12c586c9a1c452d13
parentd03068998be9cd56709c17c5fa232284ee5f607f
btrfs: return error pointer from alloc_test_extent_buffer

[ Upstream commit b6293c821ea8fa2a631a2112cd86cd435effeb8b ]

Callers of alloc_test_extent_buffer have not correctly interpreted the
return value as error pointer, as alloc_test_extent_buffer should behave
as alloc_extent_buffer. The self-tests were unaffected but
btrfs_find_create_tree_block could call both functions and that would
cause problems up in the call chain.

Fixes: faa2dbf004e8 ("Btrfs: add sanity tests for new qgroup accounting code")
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/extent_io.c
fs/btrfs/tests/qgroup-tests.c