OSDN Git Service

drm/amd/powerplay/smu10_hwmgr: use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 19 Feb 2019 18:55:09 +0000 (12:55 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 19 Feb 2019 20:58:27 +0000 (15:58 -0500)
commitbcb35dad1d3181e3cb4e5ac067bfc4aed53c592c
tree8a81e8ba71053b15292a0b7fddb6a5ff8a5248eb
parent7f5725f9802502651644e874bb9a59e66215839d
drm/amd/powerplay/smu10_hwmgr: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = kzalloc(size, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

Notice that, in this case, variable table_size is not necessary, hence
it is removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c