OSDN Git Service

net/sched: act_ct: fix ref leak when switching zones
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Thu, 24 Mar 2022 19:22:10 +0000 (16:22 -0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 27 Mar 2022 00:00:51 +0000 (17:00 -0700)
commitbcb74e132a76ce0502bb33d5b65533a4ed72d159
treec404b89362a45fc150535ceb98846de1166b1f6d
parent5ae6acf1d00be462d7b08b4a8748798ef595ae5a
net/sched: act_ct: fix ref leak when switching zones

When switching zones or network namespaces without doing a ct clear in
between, it is now leaking a reference to the old ct entry. That's
because tcf_ct_skb_nfct_cached() returns false and
tcf_ct_flow_table_lookup() may simply overwrite it.

The fix is to, as the ct entry is not reusable, free it already at
tcf_ct_skb_nfct_cached().

Reported-by: Florian Westphal <fw@strlen.de>
Fixes: 2f131de361f6 ("net/sched: act_ct: Fix flow table lookup after ct clear or switching zones")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_ct.c