OSDN Git Service

Reapply r207876 (Try simplifying LexicalScopes ownership again) including a workaroun...
authorDavid Blaikie <dblaikie@gmail.com>
Thu, 8 May 2014 22:24:51 +0000 (22:24 +0000)
committerDavid Blaikie <dblaikie@gmail.com>
Thu, 8 May 2014 22:24:51 +0000 (22:24 +0000)
commitbccff0f82d9a33ed2ea1923e614a0bf6d51812e2
treee1f925046e5e2728316bdd3bc316363322f40f65
parent50f8a53856ccfd07b70f1722863957f22db187f3
Reapply r207876 (Try simplifying LexicalScopes ownership again) including a workaround for an MSVC2012 bug regarding forward_as_tuple

(r207876 was reverted in r208131 after seeing some consistent buildbot
failure for MSVC 2012. The original commits were in r207724-r207726)

Takumi was nice enough to dig into this and locate this Microsoft
Connect issue:
http://connect.microsoft.com/VisualStudio/feedback/details/814899/forward-as-tuple-debug-implementation-error
describing a bug in MSVC2012's forward_as_tuple implementation.

Since the parameters in this instance are trivial/small, pass them by
value (using make_tuple) instead of perfectly-forwarded tuple of rvalue
references (involving the broken forward_as_tuple). Hopefully this will
satisfy MSVC2012.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208364 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/CodeGen/LexicalScopes.h
lib/CodeGen/LexicalScopes.cpp