OSDN Git Service

[CMake] Enable warnings for runtimes
authorKostya Kortchinsky <kostyak@google.com>
Fri, 27 Apr 2018 15:10:50 +0000 (15:10 +0000)
committerKostya Kortchinsky <kostyak@google.com>
Fri, 27 Apr 2018 15:10:50 +0000 (15:10 +0000)
commitbd3f6f82e4422cf9667f9ce75e8ba33b3f147dec
tree16bd107032f7ca98d26119cc3f5c735172927273
parent98eb0b867053796987f95eebdab601980703239d
[CMake] Enable warnings for runtimes

Summary:
`HandleLLVMOptions` adds `-w` to the cflags if `LLVM_ENABLE_WARNINGS` is not on.
With `-w`, `check_cxx_compiler_flag` doesn't error out for unsupported flags
(for example `-mcrc` on x86_64), and those flags end up being detected as
working - and really they aren't.

I am not entirely sure what the best way to solve this is, but setting
`LLVM_ENABLE_WARNINGS` prior to including `HandleLLVMOptions` does the job.

Reviewers: phosek, beanz

Reviewed By: phosek

Subscribers: mgorny, llvm-commits

Differential Revision: https://reviews.llvm.org/D46079

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@331042 91177308-0d34-0410-b5e6-96231b3b80d8
runtimes/CMakeLists.txt