OSDN Git Service

bpf: sockmap missing NULL psock check
authorJohn Fastabend <john.fastabend@gmail.com>
Fri, 5 Jan 2018 04:02:09 +0000 (20:02 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Mar 2018 09:24:35 +0000 (10:24 +0100)
commitbe2b86901a346d1fc2e496ce5823541ef3f82737
treea4d7b387e6e6975f1deecdf5a31e87161afe5b67
parent5ac98131312a0c16280e216e8ee6debceec11e0f
bpf: sockmap missing NULL psock check

[ Upstream commit 5731a879d03bdaa00265f8ebc32dfd0e65d25276 ]

Add psock NULL check to handle a racing sock event that can get the
sk_callback_lock before this case but after xchg happens causing the
refcnt to hit zero and sock user data (psock) to be null and queued
for garbage collection.

Also add a comment in the code because this is a bit subtle and
not obvious in my opinion.

Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/bpf/sockmap.c