OSDN Git Service

arm64/mm: Hold memory hotplug lock while walking for kernel page table dump
authorAnshuman Khandual <anshuman.khandual@arm.com>
Wed, 4 Mar 2020 04:28:42 +0000 (09:58 +0530)
committerCatalin Marinas <catalin.marinas@arm.com>
Wed, 4 Mar 2020 15:35:22 +0000 (15:35 +0000)
commitbf2b59f60ee1fefa768d62ec6e8f4b4d9e04c691
tree9e095f9ef54506598fc1c1ef8802e666d1a17838
parentf8788d86ab28f61f7b46eb6be375f8a726783636
arm64/mm: Hold memory hotplug lock while walking for kernel page table dump

The arm64 page table dump code can race with concurrent modification of the
kernel page tables. When a leaf entries are modified concurrently, the dump
code may log stale or inconsistent information for a VA range, but this is
otherwise not harmful.

When intermediate levels of table are freed, the dump code will continue to
use memory which has been freed and potentially reallocated for another
purpose. In such cases, the dump code may dereference bogus addresses,
leading to a number of potential problems.

Intermediate levels of table may by freed during memory hot-remove,
which will be enabled by a subsequent patch. To avoid racing with
this, take the memory hotplug lock when walking the kernel page table.

Acked-by: David Hildenbrand <david@redhat.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/mm/ptdump_debugfs.c