OSDN Git Service

x86/apic: Provide apic_ack_irq()
authorThomas Gleixner <tglx@linutronix.de>
Mon, 4 Jun 2018 15:33:55 +0000 (17:33 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 6 Jun 2018 13:18:20 +0000 (15:18 +0200)
commitc0255770ccdc77ef2184d2a0a2e0cde09d2b44a4
tree12d4b58e14b721fabee51115c2153a16cb697d98
parentd340ebd696f921d3ad01b8c0c29dd38f2ad2bf3e
x86/apic: Provide apic_ack_irq()

apic_ack_edge() is explicitely for handling interrupt affinity cleanup when
interrupt remapping is not available or disable.

Remapped interrupts and also some of the platform specific special
interrupts, e.g. UV, invoke ack_APIC_irq() directly.

To address the issue of failing an affinity update with -EBUSY the delayed
affinity mechanism can be reused, but ack_APIC_irq() does not handle
that. Adding this to ack_APIC_irq() is not possible, because that function
is also used for exceptions and directly handled interrupts like IPIs.

Create a new function, which just contains the conditional invocation of
irq_move_irq() and the final ack_APIC_irq().

Reuse the new function in apic_ack_edge().

Preparatory change for the real fix.

Fixes: dccfe3147b42 ("x86/vector: Simplify vector move cleanup")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Song Liu <songliubraving@fb.com>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <liu.song.a23@gmail.com>
Cc: Dmitry Safonov <0x7f454c46@gmail.com>
Cc: stable@vger.kernel.org
Cc: Mike Travis <mike.travis@hpe.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Tariq Toukan <tariqt@mellanox.com>
Link: https://lkml.kernel.org/r/20180604162224.471925894@linutronix.de
arch/x86/include/asm/apic.h
arch/x86/kernel/apic/vector.c