OSDN Git Service

media: vb2: be sure to unlock mutex on errors
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 23 Nov 2018 12:05:58 +0000 (07:05 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 23 Nov 2018 12:29:54 +0000 (07:29 -0500)
commitc06ef2e9acef4cda1feee2ce055b8086e33d251a
tree34e6521b356bdc73cbc44cc1cecf0c0af7f64875
parenta2717eae73ac4f1548fa5195adb9fafbacdfc1ad
media: vb2: be sure to unlock mutex on errors

As reported by smatch:
drivers/media/common/videobuf2/videobuf2-core.c: drivers/media/common/videobuf2/videobuf2-core.c:2159 vb2_mmap() warn: inconsistent returns 'mutex:&q->mmap_lock'.
  Locked on:   line 2148
  Unlocked on: line 2100
               line 2108
               line 2113
               line 2118
               line 2156
               line 2159

There is one error condition that doesn't unlock a mutex.

Fixes: cd26d1c4d1bc ("media: vb2: vb2_mmap: move lock up")
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/common/videobuf2/videobuf2-core.c