OSDN Git Service

watchdog: Fix possible use-after-free in wdt_startup()
authorZou Wei <zou_wei@huawei.com>
Tue, 11 May 2021 07:01:35 +0000 (15:01 +0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 21 Jun 2021 06:48:59 +0000 (08:48 +0200)
commitc08a6b31e4917034f0ed0cb457c3bb209576f542
treebeb9eafd7ed9335d31aa2c9ec6af662d7da8b644
parente0b101ab01c719a5a81b21ff16bbd33a868f9189
watchdog: Fix possible use-after-free in wdt_startup()

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/1620716495-108352-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/sbc60xxwdt.c