OSDN Git Service

test: firmware_class: report errors properly on failure
authorBrian Norris <computersforpeace@gmail.com>
Wed, 9 Dec 2015 22:50:25 +0000 (14:50 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Nov 2017 16:13:13 +0000 (17:13 +0100)
commitc08f3a82f66f6ae09a96ca0f2054da0a6d77f84d
tree9532f1dffd393b6711d366ad3f7463a2517c3cb0
parent6004eb4d1adca173f1a55dc2121f25da71e96b71
test: firmware_class: report errors properly on failure

commit 47e0bbb7fa985a0f1b5794a8653fae4f8f49de77 upstream.

request_firmware() failures currently won't get reported at all (the
error code is discarded). What's more, we get confusing messages, like:

    # echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request
    [ 8280.311856] test_firmware: loading 'notafile'
    [ 8280.317042] test_firmware: load of 'notafile' failed: -2
    [ 8280.322445] test_firmware: loaded: 0
    # echo $?
    0

Report the failures via write() errors, and don't say we "loaded"
anything.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/test_firmware.c