OSDN Git Service

tracing: Disable interrupt or preemption before acquiring arch_spinlock_t
authorWaiman Long <longman@redhat.com>
Thu, 22 Sep 2022 14:56:22 +0000 (10:56 -0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 27 Sep 2022 18:48:11 +0000 (14:48 -0400)
commitc0a581d7126c0bbc96163276f585fd7b4e4d8d0e
tree53367658e4e8bac6cd19ced260069642bb46991a
parent834168fb2ce57681dee86a405ec560f54417830c
tracing: Disable interrupt or preemption before acquiring arch_spinlock_t

It was found that some tracing functions in kernel/trace/trace.c acquire
an arch_spinlock_t with preemption and irqs enabled. An example is the
tracing_saved_cmdlines_size_read() function which intermittently causes
a "BUG: using smp_processor_id() in preemptible" warning when the LTP
read_all_proc test is run.

That can be problematic in case preemption happens after acquiring the
lock. Add the necessary preemption or interrupt disabling code in the
appropriate places before acquiring an arch_spinlock_t.

The convention here is to disable preemption for trace_cmdline_lock and
interupt for max_lock.

Link: https://lkml.kernel.org/r/20220922145622.1744826-1-longman@redhat.com
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Will Deacon <will@kernel.org>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: stable@vger.kernel.org
Fixes: a35873a0993b ("tracing: Add conditional snapshot")
Fixes: 939c7a4f04fc ("tracing: Introduce saved_cmdlines_size file")
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace.c