OSDN Git Service

selinux: ensure we cleanup the internal AVC counters on error in avc_insert()
authorPaul Moore <paul@paul-moore.com>
Tue, 10 Dec 2019 01:39:46 +0000 (20:39 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:34:41 +0000 (08:34 +0100)
commitc0d7b3faa62731f8f5fb5be2c7b8265b8e2e41a8
tree295b280667aa170d241fa6abaeac9818c983d676
parentb9df95ddb8bc50395957fb8232690006ca9625a7
selinux: ensure we cleanup the internal AVC counters on error in avc_insert()

[ Upstream commit d8db60cb23e49a92cf8cada3297395c7fa50fdf8 ]

Fix avc_insert() to call avc_node_kill() if we've already allocated
an AVC node and the code fails to insert the node in the cache.

Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
Reported-by: rsiddoji@codeaurora.org
Suggested-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
security/selinux/avc.c