OSDN Git Service

drm/i915: Skip barriers inside waits
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 27 Feb 2020 08:57:04 +0000 (08:57 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 28 Feb 2020 09:24:29 +0000 (09:24 +0000)
commitc0e310188299358279fc27c88512f94db78991a6
tree60f6d79d32c09250b9d742c3d96cc2ead9e610d6
parent69edc390a54268d41e45089cb972bf71510f5f07
drm/i915: Skip barriers inside waits

Attaching to the i915_active barrier is a two stage process, and a flush
is only effective when the barrier is activation. Thus it is possible
for us to see a barrier, and attempt to flush, only for our flush to
have no effect. As such, before attempting to activate signaling on the
fence we need to double check it is a fence!

Fixes: d13a31770077 ("drm/i915: Flush idle barriers when waiting")
Closes: https://gitlab.freedesktop.org/drm/intel/issues/1333
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200227085723.1961649-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_active.c