OSDN Git Service

drm/prime: fix extracting of the DMA addresses from a scatterlist
authorMarek Szyprowski <m.szyprowski@samsung.com>
Fri, 27 Mar 2020 16:21:26 +0000 (17:21 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Sun, 5 Apr 2020 14:44:12 +0000 (10:44 -0400)
commitc0f83d164fb8f3a2b7bc379a6c1e27d1123a9eab
treeb4a240c1160ac26cd189c80fb7215b200764c7bf
parentcc46c03397c1865a181f1a4f66d4645806e5a943
drm/prime: fix extracting of the DMA addresses from a scatterlist

Scatterlist elements contains both pages and DMA addresses, but one
should not assume 1:1 relation between them. The sg->length is the size
of the physical memory chunk described by the sg->page, while
sg_dma_len(sg) is the size of the DMA (IO virtual) chunk described by
the sg_dma_address(sg).

The proper way of extracting both: pages and DMA addresses of the whole
buffer described by a scatterlist it to iterate independently over the
sg->pages/sg->length and sg_dma_address(sg)/sg_dma_len(sg) entries.

Fixes: 42e67b479eab ("drm/prime: use dma length macro when mapping sg")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200327162126.29705-1-m.szyprowski@samsung.com
Cc: stable@vger.kernel.org
drivers/gpu/drm/drm_prime.c