OSDN Git Service

drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling
authorMarek Vasut <marex@denx.de>
Thu, 31 Mar 2022 15:05:00 +0000 (17:05 +0200)
committerRobert Foss <robert.foss@linaro.org>
Thu, 31 Mar 2022 15:20:35 +0000 (17:20 +0200)
commitc0ff7a649d62105a9308cc3ac36e52a4669d9cb4
treed9349bda577f5891a12f9d8f8ea0c78bafaf7891
parent2dcec57b3734029cc1adc5cb872f61e21609eed4
drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling

The HFP_HSW_HBP_HI register must be programmed with 2 LSbits of each
Horizontal Front Porch/Sync/Back Porch. Currently the driver programs
this register to 0, which breaks displays with either value above 255.

The HFP_MIN register must be set to the same value as HFP_LI, otherwise
there is visible image distortion, usually in the form of missing lines
at the bottom of the panel.

Fix this by correctly programming the HFP_HSW_HBP_HI and HFP_MIN registers.

Acked-by: Maxime Ripard <maxime@cerno.tech>
Fixes: ce517f18944e3 ("drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
To: dri-devel@lists.freedesktop.org
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220331150509.9838-3-marex@denx.de
drivers/gpu/drm/bridge/chipone-icn6211.c