OSDN Git Service

arm64: dts: qcom: sc7180: Fix sc7180-qmp-usb3-dp-phy reg sizes
authorDouglas Anderson <dianders@chromium.org>
Mon, 15 Mar 2021 17:38:54 +0000 (10:38 -0700)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 31 May 2021 18:05:39 +0000 (13:05 -0500)
commitc1124180eb9883891ad2acef89c9d17d6190eab4
tree103e869c1d7a38d110046bd4cfb6675e336e6def
parentdc5d91250ae6b810bc8d599d8d6590a06a4ce84a
arm64: dts: qcom: sc7180: Fix sc7180-qmp-usb3-dp-phy reg sizes

As per Dmitry Baryshkov [1]:
a) The 2nd "reg" should be 0x3c because "Offset 0x38 is
   USB3_DP_COM_REVISION_ID3 (not used by the current driver though)."
b) The 3rd "reg" "is a serdes region and qmp_v3_dp_serdes_tbl contains
   registers 0x148 and 0x154."

I think because the 3rd "reg" is a serdes region we should just use
the same size as the 1st "reg"?

[1] https://lore.kernel.org/r/ee5695bb-a603-0dd5-7a7f-695e919b1af1@linaro.org

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
Cc: Chandan Uddaraju <chandanu@codeaurora.org>
Cc: Vara Reddy <varar@codeaurora.org>
Cc: Tanmay Shah <tanmay@codeaurora.org>
Cc: Rob Clark <robdclark@chromium.org>
Fixes: 58fd7ae621e7 ("arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy")
Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20210315103836.1.I9a97120319d43b42353aeac4d348624d60687df7@changeid
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
arch/arm64/boot/dts/qcom/sc7180.dtsi