OSDN Git Service

net/sched: Change cls_flower to use IDR
authorChris Mi <chrism@mellanox.com>
Wed, 30 Aug 2017 06:31:58 +0000 (02:31 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Aug 2017 21:36:44 +0000 (14:36 -0700)
commitc15ab236d69dd6dad24541400f460c47853803f8
tree6b27a893874dd73c2e576c51fd219a3369582add
parent388f79fda74fd3d8700ed5d899573ec58c2e0253
net/sched: Change cls_flower to use IDR

Currently, all filters with the same priority are linked in a doubly
linked list. Every filter should have a unique handle. To make the
handle unique, we need to iterate the list every time to see if the
handle exists or not when inserting a new filter. It is time-consuming.
For example, it takes about 5m3.169s to insert 64K rules.

This patch changes cls_flower to use IDR. With this patch, it
takes about 0m1.127s to insert 64K rules. The improvement is huge.

But please note that in this testing, all filters share the same action.
If every filter has a unique action, that is another bottleneck.
Follow-up patch in this patchset addresses that.

Signed-off-by: Chris Mi <chrism@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_flower.c