OSDN Git Service

Xen PV backend: Disable use of O_DIRECT by default as it results in crashes.
authorAlex Bligh <alex@alex.org.uk>
Fri, 5 Apr 2013 15:45:15 +0000 (15:45 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 5 Apr 2013 15:45:15 +0000 (15:45 +0000)
commitc1a88ad1f4ac994cd70695bf08141d161e21533e
tree8149ee0f08a72ab5df39dfe670847acec0f7d18f
parent86f425db3b1c4b6c4a2927eaec35627f9ab2e703
Xen PV backend: Disable use of O_DIRECT by default as it results in crashes.

Due to what is almost certainly a kernel bug, writes with O_DIRECT may
continue to reference the page after the write has been marked as
completed, particularly in the case of TCP retransmit. In other
scenarios, this "merely" risks data corruption on the write, but with
Xen pages from domU are only transiently mapped into dom0's memory,
resulting in kernel panics when they are subsequently accessed.

This brings PV devices in line with emulated devices.  Removing
O_DIRECT is safe as barrier operations are now correctly passed
through.

See:
   http://lists.xen.org/archives/html/xen-devel/2012-12/msg01154.html
for more details.

Signed-off-by: Alex Bligh <alex@alex.org.uk>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/xen_disk.c