OSDN Git Service

b43legacy: fix a lower bounds test
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 6 Oct 2021 07:35:42 +0000 (10:35 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 11 Oct 2021 06:09:29 +0000 (09:09 +0300)
commitc1c8380b0320ab757e60ed90efc8b1992a943256
tree346d997ef014d502d8449364df755e5c4b7856e6
parent0182d0788cd66292cb1698b48dd21887d93c68ed
b43legacy: fix a lower bounds test

The problem is that "channel" is an unsigned int, when it's less 5 the
value of "channel - 5" is not a negative number as one would expect but
is very high positive value instead.

This means that "start" becomes a very high positive value.  The result
of that is that we never enter the "for (i = start; i <= end; i++) {"
loop.  Instead of storing the result from b43legacy_radio_aci_detect()
it just uses zero.

Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Büsch <m@bues.ch>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211006073542.GD8404@kili
drivers/net/wireless/broadcom/b43legacy/radio.c