OSDN Git Service

ath11k: fix a locking bug in ath11k_mac_op_start()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 9 Feb 2021 07:29:43 +0000 (09:29 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 10 Feb 2021 07:45:57 +0000 (09:45 +0200)
commitc202e2ebe1dc454ad54fd0018c023ec553d47284
treeff850434c6180388830bb03554bbc606916f6c30
parent7064e2193cabcdb8faa9008744e6ceb7f86d314d
ath11k: fix a locking bug in ath11k_mac_op_start()

This error path leads to a Smatch warning:

drivers/net/wireless/ath/ath11k/mac.c:4269 ath11k_mac_op_start()
error: double unlocked '&ar->conf_mutex' (orig line 4251)

We're not holding the lock when we do the "goto err;" so it leads to a
double unlock.  The fix is to hold the lock for a little longer.

Fixes: c83c500b55b6 ("ath11k: enable idle power save mode")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
[kvalo@codeaurora.org: move also rcu_assign_pointer() call]
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/YBk4GoeE+yc0wlJH@mwanda
drivers/net/wireless/ath/ath11k/mac.c