OSDN Git Service

Input: turbografx - fix potential out of bound access
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 30 Jul 2015 18:01:13 +0000 (11:01 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 3 Aug 2015 21:11:45 +0000 (14:11 -0700)
commitc20bc5502d151ca731ebc672b95aa77e2bf32c8c
tree0cfbf09be90866e7d1988227987b43dbbab53985
parent3213afb8bf5cf8d8c68a2c2376bf1dda52afae5d
Input: turbografx - fix potential out of bound access

Patch 17dd3f0f7aa7: "[PATCH] drivers/input/joystick: convert to dynamic
input_dev allocation" from Sep 15, 2005, leads to the following static
checker warning:

        drivers/input/joystick/turbografx.c:235 tgfx_probe()
        error: buffer overflow 'tgfx_buttons' 5 <= 5

drivers/input/joystick/turbografx.c
   195          for (i = 0; i < n_devs; i++) {
   196                  if (n_buttons[i] < 1)
   197                          continue;
   198
   199                  if (n_buttons[i] > 6) {
                            ^^^^^^^^^^^^^^^^
Possibly off by one.  >= 6.

Let's change the upper value to ARRAY_SIZE(tgfx_buttons) to ensure we do
not reach past the end of the array.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/turbografx.c