OSDN Git Service

KVM: arm64: Don't adjust PC on SError during SMC trap
authorMarc Zyngier <maz@kernel.org>
Tue, 13 Oct 2020 10:56:50 +0000 (11:56 +0100)
committerMarc Zyngier <maz@kernel.org>
Tue, 10 Nov 2020 08:34:23 +0000 (08:34 +0000)
commitc22588c99635ac4dace0ce2d55c1e2dc4f13cb54
tree211c4ef56a7f3680df90bbb60f73645339a12cd3
parentf8394f232b1eab649ce2df5c5f15b0e528c92091
KVM: arm64: Don't adjust PC on SError during SMC trap

On SMC trap, the prefered return address is set to that of the SMC
instruction itself. It is thus wrong to try and roll it back when
an SError occurs while trapping on SMC. It is still necessary on
HVC though, as HVC doesn't cause a trap, and sets ELR to returning
*after* the HVC.

It also became apparent that there is no 16bit encoding for an AArch32
HVC instruction, meaning that the displacement is always 4 bytes,
no matter what the ISA is. Take this opportunity to simplify it.

Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
arch/arm64/kvm/handle_exit.c