OSDN Git Service

tipc: fix update of the uninitialized variable err
authorColin Ian King <colin.king@canonical.com>
Mon, 11 Nov 2019 12:33:34 +0000 (12:33 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Nov 2019 06:04:03 +0000 (22:04 -0800)
commitc33fdc3453313137f8740a227525ed518bc68e28
tree39d40bd7abb0a6a8b2fec4a22d3a133d02d473bc
parent59618bc0e3949f9907ca236761bfca4ba39700e6
tipc: fix update of the uninitialized variable err

Variable err is not uninitialized and hence can potentially contain
any garbage value.  This may cause an error when logical or'ing the
return values from the calls to functions crypto_aead_setauthsize or
crypto_aead_setkey.  Fix this by setting err to the return of
crypto_aead_setauthsize rather than or'ing in the return into the
uninitialized variable

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: fc1b6d6de220 ("tipc: introduce TIPC encryption & authentication")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/crypto.c