OSDN Git Service

mlxsw: Fix some IS_ERR() vs NULL bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 22 Apr 2020 09:36:41 +0000 (12:36 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 Apr 2020 19:34:43 +0000 (12:34 -0700)
commitc391eb8366ae052d571bb2841f1ccb4d39f3ceb8
treebcb1781de82c335fe3948a179f026614adfd2772
parent829e7573c45a97e0f6a923a8e6e4589c26a26df2
mlxsw: Fix some IS_ERR() vs NULL bugs

The mlxsw_sp_acl_rulei_create() function is supposed to return an error
pointer from mlxsw_afa_block_create().  The problem is that these
functions both return NULL instead of error pointers.  Half the callers
expect NULL and half expect error pointers so it could lead to a NULL
dereference on failure.

This patch changes both of them to return error pointers and changes all
the callers which checked for NULL to check for IS_ERR() instead.

Fixes: 4cda7d8d7098 ("mlxsw: core: Introduce flexible actions support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c
drivers/net/ethernet/mellanox/mlxsw/spectrum2_acl_tcam.c
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c
drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c