OSDN Git Service

pinctrl: pistachio: fix leaked of_node references
authorWen Yang <wen.yang99@zte.com.cn>
Fri, 12 Apr 2019 06:02:19 +0000 (14:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 May 2019 13:46:16 +0000 (06:46 -0700)
commitc3933fd4a8ee310422c3c2e9ab35dd29b69fbfe1
tree7f279f6b1566e6db3c3e02d775d1a7809e57966f
parent12e7faac49e27d34714d24e40eeff6e02957df82
pinctrl: pistachio: fix leaked of_node references

[ Upstream commit 44a4455ac2c6b0981eace683a2b6eccf47689022 ]

The call to of_get_child_by_name returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./drivers/pinctrl/pinctrl-pistachio.c:1422:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1360, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/pinctrl-pistachio.c