OSDN Git Service

nvme_fc: cleanup io completion
authorJames Smart <jsmart2021@gmail.com>
Tue, 6 Feb 2018 14:48:30 +0000 (06:48 -0800)
committerSagi Grimberg <sagi@grimberg.me>
Sun, 11 Feb 2018 08:45:43 +0000 (10:45 +0200)
commitc3aedd225f8bcc3b3e61df074bc045b80542b38a
treeb5cb438d348ed5083c4fc2f0919519400939e88f
parent3efd6e8ebe19f0774c82de582849539b60cc4d97
nvme_fc: cleanup io completion

There was some old cold that dealt with complete_rq being called
prior to the lldd returning the io completion. This is garbage code.
The complete_rq routine was being called after eh_timeouts were
called and it was due to eh_timeouts not being handled properly.
The timeouts were fixed in prior patches so that in general, a
timeout will initiate an abort and the reset timer restarted as
the abort operation will take care of completing things. Given the
reset timer restarted, the erroneous complete_rq calls were eliminated.

So remove the work that was synchronizing complete_rq with io
completion.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
drivers/nvme/host/fc.c