OSDN Git Service

drm/lima: avoid error task dump attempt when not enabled
authorErico Nunes <nunes.erico@gmail.com>
Wed, 9 Feb 2022 09:37:00 +0000 (10:37 +0100)
committerQiang Yu <yuq825@gmail.com>
Sat, 12 Feb 2022 04:17:15 +0000 (12:17 +0800)
commitc49fcb5c195777c1a35ad96f01435b6d23448d27
treebbc7407d2694824f95868272ce0e4856c9dbee25
parentc7703ce38c1ecdeeea6791b54fbee29a08816ea9
drm/lima: avoid error task dump attempt when not enabled

Currently when users try to run an application with lima and that hits
an issue such as a timeout, a message saying "fail to save task state"
and "error task list is full" is shown in dmesg.

The error task dump is a debug feature disabled by default, so the
error task list is usually not going to be available at all.
The message can be misleading and creates confusion in bug reports.

We can avoid that code path and that particular message when the user
has not explicitly set the max_error_tasks parameter to enable the
feature.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220209093700.30901-1-nunes.erico@gmail.com
drivers/gpu/drm/lima/lima_sched.c